Fix CatBoost.get_params() TypeError in test_regression#1520
Merged
jianglibigdata merged 2 commits intomainfrom Feb 24, 2026
Merged
Fix CatBoost.get_params() TypeError in test_regression#1520jianglibigdata merged 2 commits intomainfrom
jianglibigdata merged 2 commits intomainfrom
Conversation
…gument CatBoost's get_params() no longer accepts positional arguments beyond self. The test was passing "n_estimators" as a positional argument which was being interpreted as the deep parameter. Changed to extract the n_estimators value from the returned params dict instead. Co-authored-by: thinkall <3197038+thinkall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TypeError in CatBoost.get_params() method
Fix CatBoost.get_params() TypeError in test_regression
Feb 24, 2026
jianglibigdata
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent CatBoost versions removed the
deepparameter fromget_params(), causingtest_regressionto fail when CatBoost is selected as the best model.The test was calling
get_params("n_estimators")where the string was silently consumed as thedeeppositional arg on sklearn-compatible models, but CatBoost now rejects it outright.automl.model.estimator.get_params("n_estimators")→automl.model.estimator.get_params().get("n_estimators")on lines 57 and 89, which also corrects the original intent (variable is namedn_iterbut was storing the full params dict)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.