Clean up logging from NoTargets projects#300
Merged
jeffkl merged 4 commits intomicrosoft:mainfrom Nov 4, 2021
Merged
Conversation
A NoTargets project will still log (with high importance) something like: > MyProject -> Leaving a blank where the primary output would typically go. This looks weird. So this change removes that from being logged. It also disables (because it's the same property that controls it) copying of the primary output that we didn't build.
jeffkl
reviewed
Oct 9, 2021
Contributor
jeffkl
left a comment
jeffkl
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution. Can you please add the condition and add the new property to this unit test so it doesn't regress in future commits:
jeffkl
approved these changes
Nov 4, 2021
Contributor
jeffkl
left a comment
jeffkl
left a comment
There was a problem hiding this comment.
Sorry for the delay, GitHub didn't notify me that changes were pushed for some reason.
Thank you for the contribution!
Member
Author
|
@jeffkl Looks like it failed due to a network outage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NoTargets project will still log (with high importance) something like:
Leaving a blank where the primary output would typically go. This looks weird. So this change removes that from being logged. It also disables (because it's the same property that controls it) copying of the primary output that we didn't build.