Skip to content

Conversation

@ViktorHofer
Copy link
Member

Fixes #431

Unrelated question: Why do the Traversal and the NoTargets projects target net40?

@jeffkl
Copy link
Contributor

jeffkl commented Apr 13, 2023

Unrelated question: Why do the Traversal and the NoTargets projects target net40?

In order to load the projects in Visual Studio, you need to specify a target framework. I think at the time I just picked the lowest one? The target framework shouldn't be used anywhere so it could probably be anything.

Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jeffkl jeffkl merged commit cef0a8d into microsoft:main Apr 13, 2023
@ViktorHofer ViktorHofer deleted the SuppressDependenciesWhenPackagingMsBuildSdks branch April 13, 2023 15:53
@ViktorHofer
Copy link
Member Author

In order to load the projects in Visual Studio, you need to specify a target framework. I think at the time I just picked the lowest one? The target framework shouldn't be used anywhere so it could probably be anything.

Sorry, I should have elaborated. I meant the build target framework in this repository for the projects: <TargetFrameworks>net40;netstandard2.0</TargetFrameworks>.

@jeffkl
Copy link
Contributor

jeffkl commented Apr 13, 2023

Oh I think it so we can run tests against multiple frameworks. net40 and netstandard2.0 are the most compatible with runtime frameworks:

https://github.com/microsoft/MSBuildSdks/blob/main/src/CentralPackageVersions.UnitTests/Microsoft.Build.CentralPackageVersions.UnitTests.csproj#L3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are the msbuild sdk nuget package dependencies necessary

2 participants