[GLTF-Import] Files get ignored, when File ending is not lower case#7141
Merged
keveleigh merged 2 commits intomicrosoft:mrtk_developmentfrom Jan 24, 2020
Merged
[GLTF-Import] Files get ignored, when File ending is not lower case#7141keveleigh merged 2 commits intomicrosoft:mrtk_developmentfrom
keveleigh merged 2 commits intomicrosoft:mrtk_developmentfrom
Conversation
cefoot
requested review from
david-c-kline,
keveleigh and
wiwei
as code owners
Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/GltfUtility.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/GltfUtility.cs
Outdated
Show resolved
Hide resolved
Troy-Ferrell
approved these changes
Jan 24, 2020
Contributor
Troy-Ferrell
left a comment
Troy-Ferrell
left a comment
There was a problem hiding this comment.
Switch to using the StringComparison enum. This way we aren't duplicating memory to create the lower case version
Otherwise good find!
keveleigh
added
the
GLTF
Contributor
Author
|
Now using StringComparison enum instead of ToLower(). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
Jan 24, 2020
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When trying to import GLTF or GLB files with upper case File ending f.e. "Video camera.GLB" the GlbAssetImporter Script get's triggerd but inside GltfEditorImporter.OnImportGltfAsset the file get's ignored because the file ending is not lower case.