MRTK Toolbox

[Troy-Ferrell]

Overview

The Mixed Reality Toolkit could use a toolbox! Inspired to make this after realizing that we had progress indicator prefabs available in MRTK....and I didn't even know they existed.

The purpose of this toolbox is similar to other frameworks such as WPF etc, one could easily drag and drop pre-built components from a toolbox. Drag'n'drop proved to be harder than I imagined so I opted to just use a grid of buttons for the short term.

Updated UI:

Changes

• Fixes: # TBD

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

[thalbern]

Love this!!!!!! That's amazing @Troy-Ferrell 🎆

[thalbern]

If this is not in experimental we would need a doc page for it and also i would write a test that ensures that all the prefabs in the json file are available and instantiable.

[wiwei]

Is this the fabled Mixed Reality Toolkit Toolbox?!

But actually this is pretty neat - going forward we'll have to figure out how to add another suffix on maybe...

Mixed Reality Toolkit Toolbox Toolset?

[Troy-Ferrell]

If this is not in experimental we would need a doc page for it and also i would write a test that ensures that all the prefabs in the json file are available and instantiable.

Indeed! I forgot to add this last night to the draft.

@thalbern I am actually interested in people's thoughts on making this experimental or not.

[SimonDarksideJ]

Very interesting development @Troy-Ferrell , will be watching intently. Although, why build it im imgui, this would be a lot better in ui elements (granted, not sure thats available in 2018)

[Troy-Ferrell]

Very interesting development @Troy-Ferrell , will be watching intently. Although, why build it im imgui, this would be a lot better in ui elements (granted, not sure thats available in 2018)

Yes I am not aware that the new Unity UI Elements in available/truly supported in 2018. I also have less experience with that API compared to IMGUI, which is also how everything else in MRTK is built

[cre8ivepark]

This is beautiful @Troy-Ferrell ! I'll work on the thumbnail images. what's the recommended width x height to make it fill the button without distortion?

[thalbern]

If this is not in experimental we would need a doc page for it and also i would write a test that ensures that all the prefabs in the json file are available and instantiable.

Indeed! I forgot to add this last night to the draft.

@thalbern Bernadette Thalhammer FTE I am actually interested in people's thoughts on making this experimental or not.

imo we should follow our feature guidelines that say that new features have to be covered by tests and documentation - I think one test that checks if those prefabs are valid should be fine and a small article / paragraph / mention about the toolbox in the docs.

[cre8ivepark]

@Troy-Ferrell Is it possible to use existing images in the Documentation folder?
for example:
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk_development/Documentation/Images/Button/MRTK_Button_Prefabs_HoloLens2.png
I tried this but it seems not working:
"RelativeIconPath": "\Documentation\Images\Button\MRTK_Button_Prefabs_HoloLens2.png",

[Troy-Ferrell]

@thalbern yes, that makes sense. Adding a test and some docs is trivial. It's more just a question if it should be experimental to begin with or not

@cre8ivepark I copied a lot of the photos from the documentation folder into the new folder under Assets\MRTK. But we can't use the existing documentation folder directly, especially since the documentation doesn't ship as part of the unity packages.

The RelativeIconPath in the JSON is the relative path under "Assets/MixedRealityToolkit/" only (because of the module path setting = 1)

@cre8ivepark regarding to size...I'd say 128x128 or maybe 256x256? Whatever their resolution is, they'll be down-sampled to fit in the button which is like 150 pixels

[cre8ivepark]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[julenka]

Suggestion: I noticed that release notes are not included in this change. It would be good to mention this cool new feature in our release notes for 2.4.

[keveleigh]

@cre8ivepark I think it's time to give this one more test, when you get a chance, with my changes to the Unity UI section. Pending that, anybody else's tests, and @julenka's request for adding this to the release notes, I think we're good to go!

[keveleigh]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[CDiaz-MS]

Tested out the new Unity UI element portion and it works for me.

[cre8ivepark]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[cre8ivepark]

Added minor polish for the information text!
Tested and works well!

[keveleigh]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[cre8ivepark]

@keveleigh I'll fix the docs error

[cre8ivepark]

@keveleigh Fixed TOC issue.

[cre8ivepark]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[keveleigh]

@cre8ivepark Ah shoot, my bad. Thanks for fixing!