-
Notifications
You must be signed in to change notification settings - Fork 20
Migrate GitHub Pages deployment to official first-party actions #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Replace peaceiris/actions-gh-pages@v3 with actions/upload-pages-artifact@v3 and actions/deploy-pages@v4 - Add workflow-level permissions (contents: read, pages: write, id-token: write) - Split into build and deploy jobs following first-party action requirements - Add concurrency control to prevent simultaneous deployments - Update actions/checkout@v2 to @v4 and actions/setup-dotnet@v1 to @v4 Co-authored-by: gfs <[email protected]>
|
@copilot lets use .net 10 instead of 8 since thats the latest currently supported |
- Change dotnet-version from 8.0.x to 10.0.x - Update target framework from net8.0 to net10.0 Co-authored-by: gfs <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the GitHub Pages deployment workflow from the third-party peaceiris/actions-gh-pages@v3 to official GitHub first-party actions (actions/upload-pages-artifact@v3 and actions/deploy-pages@v4). The migration aligns with GitHub's recommended OIDC-based deployment pattern and addresses security concerns with third-party actions. However, the PR also includes an unrelated .NET version upgrade from 8 to 10, which introduces critical issues since .NET 10 does not yet exist.
Changes:
- Split workflow into separate
buildanddeployjobs as required by official GitHub Pages actions - Updated action versions (checkout@v2→v4, setup-dotnet@v1→v4) and migrated to first-party deployment actions
- Added workflow-level permissions and concurrency controls for OIDC authentication
- Attempted to upgrade .NET version from 8 to 10 (problematic - see issues below)
Comments suppressed due to low confidence (1)
.github/workflows/publish-wasm-and-docs-to-gh-pages.yml:32
- The build command references 'net10.0' target framework, but the OAT.Blazor project file (OAT.Blazor/OAT.Blazor.csproj line 4) only targets net8.0. This mismatch will cause the build to fail. The project file needs to be updated to target net10.0, or this command should be changed to use net8.0 instead.
run: dotnet publish OAT.Blazor -c Release -f net10.0 -o blazorOut
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Replaces third-party
peaceiris/actions-gh-pages@v3with official GitHub Pages actions using OIDC authentication.Changes
buildanddeployjobs per first-party action requirementscontents: read,pages: write,id-token: writefor OIDCactions/upload-pages-artifact@v3+actions/deploy-pages@v4pagesgroup to prevent simultaneous deploymentscheckout@v2→@v4,setup-dotnet@v1→@v4Before/After
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.