Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

Replaces third-party peaceiris/actions-gh-pages@v3 with official GitHub Pages actions using OIDC authentication.

Changes

  • Workflow structure: Split into build and deploy jobs per first-party action requirements
  • Permissions: Workflow-level contents: read, pages: write, id-token: write for OIDC
  • Deployment: actions/upload-pages-artifact@v3 + actions/deploy-pages@v4
  • Concurrency: Added pages group to prevent simultaneous deployments
  • Action versions: Updated checkout@v2@v4, setup-dotnet@v1@v4
  • .NET version: Updated from .NET 8 to .NET 10

Before/After

# Before
- uses: peaceiris/actions-gh-pages@v3
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    publish_dir: toPublish

# After (build job)
- uses: actions/upload-pages-artifact@v3
  with:
    path: toPublish

# After (deploy job)
- uses: actions/deploy-pages@v4
Original prompt

Migrate #390 to be a PR against main rather than the alert pr.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Replace peaceiris/actions-gh-pages@v3 with actions/upload-pages-artifact@v3 and actions/deploy-pages@v4
- Add workflow-level permissions (contents: read, pages: write, id-token: write)
- Split into build and deploy jobs following first-party action requirements
- Add concurrency control to prevent simultaneous deployments
- Update actions/checkout@v2 to @v4 and actions/setup-dotnet@v1 to @v4

Co-authored-by: gfs <[email protected]>
Copilot AI changed the title [WIP] Migrate PR #390 to target main branch Migrate GitHub Pages deployment to official first-party actions Feb 4, 2026
Copilot AI requested a review from gfs February 4, 2026 23:50
@gfs
Copy link
Contributor

gfs commented Feb 5, 2026

@copilot lets use .net 10 instead of 8 since thats the latest currently supported

- Change dotnet-version from 8.0.x to 10.0.x
- Update target framework from net8.0 to net10.0

Co-authored-by: gfs <[email protected]>
Copy link
Contributor Author

Copilot AI commented Feb 5, 2026

@copilot lets use .net 10 instead of 8 since thats the latest currently supported

Updated the workflow to use .NET 10 in commit 38a4e13. Changed dotnet-version from 8.0.x to 10.0.x and the build target framework from net8.0 to net10.0.

@gfs
Copy link
Contributor

gfs commented Feb 5, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs
Copy link
Contributor

gfs commented Feb 5, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the GitHub Pages deployment workflow from the third-party peaceiris/actions-gh-pages@v3 to official GitHub first-party actions (actions/upload-pages-artifact@v3 and actions/deploy-pages@v4). The migration aligns with GitHub's recommended OIDC-based deployment pattern and addresses security concerns with third-party actions. However, the PR also includes an unrelated .NET version upgrade from 8 to 10, which introduces critical issues since .NET 10 does not yet exist.

Changes:

  • Split workflow into separate build and deploy jobs as required by official GitHub Pages actions
  • Updated action versions (checkout@v2→v4, setup-dotnet@v1→v4) and migrated to first-party deployment actions
  • Added workflow-level permissions and concurrency controls for OIDC authentication
  • Attempted to upgrade .NET version from 8 to 10 (problematic - see issues below)
Comments suppressed due to low confidence (1)

.github/workflows/publish-wasm-and-docs-to-gh-pages.yml:32

  • The build command references 'net10.0' target framework, but the OAT.Blazor project file (OAT.Blazor/OAT.Blazor.csproj line 4) only targets net8.0. This mismatch will cause the build to fail. The project file needs to be updated to target net10.0, or this command should be changed to use net8.0 instead.
      run: dotnet publish OAT.Blazor -c Release -f net10.0 -o blazorOut

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gfs
Copy link
Contributor

gfs commented Feb 5, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs gfs marked this pull request as ready for review February 10, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants