Repository navigation
FIX: Keep combining marks inside words masked by SATAMaskingConverter - #4390
Merged
jbolor21 merged 1 commit intoNov 19, 2026
Merged
Conversation
Trailing accents and vowel signs are not \w, so they were split off as punctuation and left after the mask, leaking part of the hidden word ("café" -> "[MASK]́", "नमस्ते" -> "[MASK]े").
jbolor21
approved these changes
Nov 19, 2026
jbolor21
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Running through our pipelines and we will merge in thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4389.
SATAMaskingConverterkeeps the punctuation around a masked word and replaces the word itself, but its trailing-punctuation pattern counted combining marks (Unicode categoryM*: decomposed accents, Indic vowel signs) as punctuation, because they are not\w. So a word ending in one leaked that mark after the mask:"café"(decomposed) became"[MASK]́"and"नमस्ते"became"[MASK]े"."café!"→"[MASK]!") is still kept.tests/unit/converterpasses (3175 passed, 52 skipped), and pre-commit passes on the changed files.