Repository navigation
MAINT: Enable the full Ruff F rule family - #4466
Open
Cheikh Ahmed Tidiane Thiandoum (imRYiUK) wants to merge 5 commits into
Open
Cheikh Ahmed Tidiane Thiandoum (imRYiUK) wants to merge 5 commits into
Cheikh Ahmed Tidiane Thiandoum (imRYiUK) wants to merge 5 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
CLA is signed. Roman Lutz (@romanlutz) could you approve the workflow run here and take a look when you have a moment? |
Fix the outstanding pyflakes findings and select F instead of only F401 and F821. Top-level await in doc/ notebooks is reported as F704, so it is ignored there like PLE1142.
Cheikh Ahmed Tidiane Thiandoum (imRYiUK)
force-pushed
the
maint/enable-ruff-f-family
branch
from
November 20, 2026 21:35
3221d2a to
232a057
Compare
remove F704 to narrow this ruff exception
adding F704 back
Tightened the [schema test] - Renamed to `test_print_schema_lists_id_for_prompt_memory_entry`. Kept the setup and `obj._print_schema()` call. Replaced the output assertions with these so an `id` from a different table cannot make the test pass
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the outstanding pyflakes findings and selects the full
Ffamily in Ruff (it was limited toF401andF821). This is theFstage of #3721; the ASYNC240/ASYNC250 stage is tracked separately.pyrit/: rename loop variables that shadowed imports inmemory_interface.pyandmemory_models.py, drop a redundantTYPE_CHECKINGimport inscenario.py, and remove an unused variable inwildguard_scorer.py.tests/,docker/,doc/: remove unused variables and placeholder-less f-strings, plus a few redundant imports.test_seed.py,test_fallback_scorer.py) had their first definition silently shadowed and never run. The later ones are renamed so both run, and both pass.benchmark_app,sqlite_instance, ...) are marked# noqa: F811.pyproject.toml: selectF, and ignoreF704underdoc/**, since top-levelawaitis valid in notebooks and Ruff reports it asF704. This sits next to the existingPLE1142ignore.Measured with Ruff 0.17.4 (the pre-commit pin) on current main.
ruff check .andruff format --check .pass.Related to #3721