Skip to content

MAINT: Make AttackExecutor's nested helpers keyword-only - #4491

Open
Aditya Malkar (adimalkar) wants to merge 1 commit into
microsoft:mainfrom
adimalkar:maint/4216-attack-executor-keyword-only
Open

Aditya Malkar (adimalkar) wants to merge 1 commit into
microsoft:mainfrom
adimalkar:maint/4216-attack-executor-keyword-only

Conversation

@adimalkar

Copy link
Copy Markdown
Contributor

Description

Make the two private helpers nested in AttackExecutor keyword-only, and clear them from the keyword-only baseline.

  • build_params_async (in execute_attack_from_seed_groups_async) and run_one_async (in _execute_with_params_list_async) take their parameters after *.
  • Their only call sites, the list comprehensions that build the gathered tasks, pass the arguments by name.
  • Remove the two entries from build_scripts/keyword_only_baseline.txt.
  • No behavior change: both helpers are local closures, so nothing outside these methods can call them.

Relates to #4216

This change was developed with AI assistance (Claude Code).

build_params_async and run_one_async take their parameters after *, their
list-comprehension call sites pass them by name, and the two entries leave
the keyword-only baseline.

Relates to microsoft#4216
Copilot AI balanced review requested due to automatic review settings November 21, 2026 05:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants