Repository navigation
MAINT: Make AttackExecutor's nested helpers keyword-only - #4491
Open
Aditya Malkar (adimalkar) wants to merge 1 commit into
Open
Aditya Malkar (adimalkar) wants to merge 1 commit into
Aditya Malkar (adimalkar) wants to merge 1 commit into
Conversation
build_params_async and run_one_async take their parameters after *, their list-comprehension call sites pass them by name, and the two entries leave the keyword-only baseline. Relates to microsoft#4216
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the two private helpers nested in
AttackExecutorkeyword-only, and clear them from the keyword-only baseline.build_params_async(inexecute_attack_from_seed_groups_async) andrun_one_async(in_execute_with_params_list_async) take their parameters after*.build_scripts/keyword_only_baseline.txt.Relates to #4216
This change was developed with AI assistance (Claude Code).