This repository was archived by the owner on Aug 21, 2024. It is now read-only.
[GraphColoring] Workbook Part1 (Tasks 1.1 - 1.5)#509
Merged
tcNickolas merged 16 commits intomicrosoft:mainfrom Oct 11, 2020
Merged
[GraphColoring] Workbook Part1 (Tasks 1.1 - 1.5)#509tcNickolas merged 16 commits intomicrosoft:mainfrom
tcNickolas merged 16 commits intomicrosoft:mainfrom
Conversation
Contributor
|
I'm doing a cleanup pass on the workbook now, and discovered a bug which causes the reference solution for task 1.5 to fail. I sent a PR to fix it (#527), once that one is merged the CI failure should be fixed. |
tcNickolas
approved these changes
Oct 11, 2020
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good. I did a round of cleanup, using the workbook-style introduction in the workbook (rather than kata-style introduction) and polishing the explanations a bit. This should be good to go once #527 is merged.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is as per the discussion here
It includes solutions and explanations for Tasks 1.1 - 1.5
I have written a different solution for Task 1.4 as compared to ReferenceImplementation in order to create a flow for the next task 1.5
It creates a partial Workbook for GraphColoring Kata with @BrokenDuck working on the other half consisting of Tasks 2.1-2.3.