This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improve code quality in MachineLearning library #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
approved these changes
Mar 10, 2022
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Nice to highlight how recent Q# features really help improve code quality!
| nMeasurements : Int | ||
| ) : Double { | ||
| return EstimateRealOverlapBetweenStates( | ||
| _ApplyLEOperationToRawRegister(inputEncoder::Prepare, _), |
Contributor
There was a problem hiding this comment.
We should test to make sure that the library still works when used from IQ#, given microsoft/iqsharp#606.
Contributor
There was a problem hiding this comment.
Most likely it won't, I ran into this when trying to update the Katas - even if the lambda is in the "backend" and not in the notebook itself, compilation fails
Member
Author
There was a problem hiding this comment.
Thanks for this information. Maybe it makes sense to leave this open until microsoft/iqsharp#606 is resolved.
Co-authored-by: Cassandra Granade <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.