Skip to content

filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer #5976

AZero13 wants to merge 1 commit into from
+1 −1

Conversation

@AZero13
Copy link
Contributor

@AZero13 AZero13 commented Dec 27, 2025

No description provided.

@AZero13 AZero13 requested a review from a team as a code owner December 27, 2025 03:52
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Dec 27, 2025
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 31, 2025

This certainly appears to be a bug, after looking into how FSCTL_GET_REPARSE_POINT and FSCTL_SET_REPARSE_POINT work. This codepath is used in a single place, when copying a junction. I'll need to manually exercise this scenario (automated test coverage could potentially be problematic).

@StephanTLavavej StephanTLavavej added bug Something isn't working filesystem C++17 filesystem labels Dec 31, 2025
@StephanTLavavej StephanTLavavej changed the title Bug: We should use the size of the buffer, not buffer pointer filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer Dec 31, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Work In Progress in STL Code Reviews Jan 5, 2026
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 5, 2026

We don't think this fix is correct, sizeof(*_Buffer) contains a "fake" array element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working filesystem C++17 filesystem

Projects

STL Code Reviews
Status: Work In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AZero13 @StephanTLavavej