Add all imports inserts all commas before imports in files with crlf line endings

[karthiknadig]

TS Template added by @mjbvz

TypeScript Version: 4.0.0-dev.20200708

Search Terms

• windows
• crlf
• Add all missing imports

---

Issue Type: Bug

Copy some code into an existing TS file, and select "add all missing imports" form the quick fix.

Before:

After:

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2304)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	63.78GB (48.88GB free)
Process Argv	--file-uri file:///c%3A/GIT/s%20p/vscode-python/pvsc.code-workspace
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
gitlens	eam	10.2.2
EditorConfig	Edi	0.15.1
prettier-vscode	esb	5.1.3
vscode-pull-request-github	Git	0.17.0
python	ms-	2020.6.91350
vscode-pylance	ms-	2020.6.1
remote-containers	ms-	0.122.1
remote-ssh	ms-	0.51.0
remote-ssh-edit	ms-	0.51.0
remote-wsl	ms-	0.44.4
vscode-typescript-tslint-plugin	ms-	1.2.3
code-spell-checker	str	1.9.0

[mjbvz]

Does this reproduce with all extensions disabled?

Also, please share some example code (as text) that demonstrates this issue

[karthiknadig]

Yes it repros with all extensions disabled.

To exactly repro the above scenario:

1. git check out this branch : https://github.com/karthiknadig/vscode-python/tree/consolidate
2. go to this file src/client/pythonEnvironments/main.ts
3. Replace the first import with this:

import {
    CONDA_ENV_FILE_SERVICE,
    CONDA_ENV_SERVICE,
    CURRENT_PATH_SERVICE,
    GLOBAL_VIRTUAL_ENV_SERVICE,
    ICondaService
} from '../interpreter/contracts';

4. Use quickfix to add all missing imports

[mjbvz]

I don't see main.ts but tested in src/client/pythonEnvironments/legacyIOC.ts and could not reproduce on MacOS:

But I can repo the error Windows (possibly because of \r\n)?

[mjbvz]

Minimal repo:

https://github.com/mjbvz/ts-39515

Again, only could repo on windows

[mjbvz]

Also confirmed that changing line endings to \n fixes the problem.

[mjbvz]

TS Server trace

[Trace  - 02:24:06.406] <semantic> Response received: getCombinedCodeFix (80). Request took 7 ms. Success: true 
Result: {
    "changes": [
        {
            "fileName": "c:/Users/matb/projects/san/index.ts",
            "textChanges": [
                {
                    "start": {
                        "line": 3,
                        "offset": 7
                    },
                    "end": {
                        "line": 3,
                        "offset": 7
                    },
                    "newText": ","
                },
                {
                    "start": {
                        "line": 3,
                        "offset": 7
                    },
                    "end": {
                        "line": 3,
                        "offset": 7
                    },
                    "newText": ","
                },
                {
                    "start": {
                        "line": 3,
                        "offset": 8
                    },
                    "end": {
                        "line": 3,
                        "offset": 8
                    },
                    "newText": "\n    a3"
                },
                {
                    "start": {
                        "line": 3,
                        "offset": 8
                    },
                    "end": {
                        "line": 3,
                        "offset": 8
                    },
                    "newText": "\n    a4"
                }
            ]
        }
    ]
}