Handle getScriptVersion correctly to ensure program structure is checked correctly#36808
Merged
sheetalkamat merged 6 commits intomasterfrom Feb 26, 2020
Merged
Handle getScriptVersion correctly to ensure program structure is checked correctly#36808sheetalkamat merged 6 commits intomasterfrom
sheetalkamat merged 6 commits intomasterfrom
Conversation
sheetalkamat
requested review from
RyanCavanaugh,
amcasey,
andrewbranch,
elibarzilay,
orta,
rbuckton,
sandersn and
weswigham
…ojectReferenceRedirect
…ked correctly Fixes #36748
This means earlier we were creating fresh program everytime we did LS operation Now we reuse same program, so quick info depends on order of quickinfo demands
…valuated before finding references, it cant find all definitions from the merge
sheetalkamat
force-pushed
the
isUptoDate
branch
from
cdb2871 to
05ccdcf
Compare
sandersn
reviewed
Feb 19, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I don't have enough context to understand this change. From the bug, it sounds like the fix applies to language service API users. Does it affect our usage of the language service too?
sandersn
reviewed
Feb 19, 2020
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Member
Author
|
@sandersn have resolved all the comments.. Please take a look.. thanks |
sandersn
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36748