Some cleanup around inlay hints types to get more-precise checking.#45391
Merged
DanielRosenwasser merged 2 commits intomainfrom Aug 23, 2021
Merged
Some cleanup around inlay hints types to get more-precise checking.#45391DanielRosenwasser merged 2 commits intomainfrom
DanielRosenwasser merged 2 commits intomainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
Member
|
@DanielRosenwasser does this need to go into 4.4? |
DanielRosenwasser
force-pushed
the
inlayHintsTypeCleanup
branch
from
6101d34 to
a2cefc5
Compare
Member
Author
|
@typescript-bot cherry-pick this to release-4.4 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #45529 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 21, 2021
Component commits: a2cefc5 Some cleanup around inlay hints types to get more-precise checking.
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 23, 2021
…45391) * Some cleanup around inlay hints types to get more-precise checking. * Update Baselines and/or Applied Lint Fixes Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
This was referenced Sep 25, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
…icrosoft#45391) * Some cleanup around inlay hints types to get more-precise checking. * Update Baselines and/or Applied Lint Fixes Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, inlay hints incorrectly report that their
kindmight be optional. We also don't validate that the response has the shape that we're promising, so this PR ensures that we get at least some checking there.