fix(45802): keep children of mismatched jsx element #45839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Sep 16, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Very nice fix. The comments just need a couple of updates too.
Co-authored-by: Nathan Shively-Sanders <[email protected]>
Contributor
Author
|
Thanks for the review! I updated comments with your suggestion. I just tried Github's commit suggestion button, so git log looks a bit funny but I hope you don't mind. |
sandersn
approved these changes
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45802
This PR attempts to fix small regression of the PR #43780. I have to say I still don't see the whole picture of jsx parsing routines, so my fix might not be to the point.
If maintainers have other solutions in mind, please feel free to close my PR.
I added a few tests to verify that the crash is now fixed. There are also baseline changes which shows how mismatched jsx parsing differs after this fix.
Thanks for the code review!