Fix declaration emit for symbol property keys from external modules#63110
Draft
Fix declaration emit for symbol property keys from external modules#63110
Conversation
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing symbol property keys in declaration file
Fix declaration emit for symbol property keys from external modules
Feb 6, 2026
Member
|
@copilot keep at it |
When a type uses a unique symbol from an external module as a property key, check if the symbol is directly accessible as a value. If not, report a non-serializable property error instead of silently emitting a broken declaration file with an undefined reference. Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Add accessibility check in getPropertyNameNodeForSymbolFromNameType to detect when a unique symbol from an external module cannot be directly accessed as a value. Reports a non-serializable property error to prevent generating broken declaration files with undefined symbol references. Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPropertyNameNodeForSymbolFromNameTypeandaddPropertyToElementListuniqueSymbolPropertyDeclarationEmit)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.