Conversation
…r, non-elevated shells will have elevated virtiofs access.
Brian-Perkins
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a security issue where VirtioFS mounts incorrectly inherit elevated access rights when the VM is launched by an elevated user, even when accessed from non-elevated shells. The fix ensures that the appropriate VirtioFS class ID is selected based on the token's elevation status when WSLg (GUI applications) is enabled.
Key changes:
- Modified virtiofs device initialization to use elevation-aware class ID selection
- Added comprehensive tests to validate elevated and non-elevated access with WSLg enabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/windows/service/exe/WslCoreVm.cpp | Implements the fix by checking token elevation and selecting the appropriate VIRTIO_FS class ID (admin vs non-admin) when adding the wslg shared memory device |
| test/windows/DrvFsTests.cpp | Adds two new test methods (DrvfsMountElevatedSystemDistroEnabled and DrvfsMountNonElevatedSystemDistroEnabled) that validate the fix by testing mount types and file creation permissions with WSLg enabled |
Brian-Perkins
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue with virtiofs when WSLg is enabled. If an elevated token launches the VM, then all virtiofs access will have access rights of the launching token. A test was added to validate the fix, the previous tests did not hit this because they run with WSLg disabled.