Implement image save and export container #14121
Conversation
ptrivedi
requested review from
OneBlue,
benhillis,
Copilot,
craigloewen-msft and
justus-camp-microsoft
| VERIFY_IS_TRUE(GetFileSizeEx(contTarFileHandle.get(), &fileSize)); | ||
| VERIFY_ARE_EQUAL(fileSize.QuadPart > 0, false); | ||
| WSLA_ERROR_INFO errorInfo{}; | ||
| VERIFY_FAILED(m_defaultSession->ExportContainer(HandleToULong(contTarFileHandle.get()), "dummy", nullptr, &errorInfo)); |
There was a problem hiding this comment.
I recommend validating the error code here, so we know that we're correctly handling the error (although if we move this method to WSLAContainer that will solve this since Open() will fail on invalid name / id)
There was a problem hiding this comment.
Error code doesn't bubble up to here. We are verifying the error message. This is the same model as is used in ImportImage etc.
Not opposed to moving it to WSLAContainer though
There was a problem hiding this comment.
The error code should definitely get returned to the client (that's the HRESULT that VERIFY_FAILED() is looking at), but yeah this doesn't apply if we move all of this to WSLAContainer, which I think would be the best approach here
Co-authored-by: Copilot <[email protected]>
…om/microsoft/WSL into user/ptrivedi/saveimage-exportcont
| return {parser.get().result_int(), std::move(context)}; | ||
| } | ||
|
|
||
| std::pair<uint32_t, wil::unique_socket> DockerHTTPClient::SendRequest( |
There was a problem hiding this comment.
I think we should remove this, since ExportContainer() only uses the socket and none of the other fields in the context, we can directly use this method
No description provided.