build: ensure wsla deps are declared in build-stage.yml and msi package dependencies#14180
build: ensure wsla deps are declared in build-stage.yml and msi package dependencies#14180benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WSL build pipeline and MSI packaging inputs to include the WSLA service proxy stub so it gets built/signed and tracked as a packaging dependency.
Changes:
- Add
wslaservice/wslaserviceproxystubto the build-stage target list and code-signing copy pattern. - Add
wslaserviceproxystub.dllto the MSI package dependency inputs (WINDOWS_BINARIES).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
msipackage/CMakeLists.txt |
Ensures the MSI build target depends on the WSLA proxy stub binary input so packaging can rebuild when it changes. |
.pipelines/build-stage.yml |
Ensures WSLA service binaries are built, signed, and copied into the staging directory used for MSI packaging in release builds. |
| set(PACKAGE_WIX ${BIN}/package.wix) | ||
| set(CAB_CACHE ${BIN}/cab) | ||
| set(WINDOWS_BINARIES wsl.exe;wslg.exe;wslhost.exe;wslrelay.exe;wslservice.exe;wslserviceproxystub.dll;wslinstall.dll;wslaservice.exe;wsladiag.exe;wslc.exe) | ||
| set(WINDOWS_BINARIES wsl.exe;wslg.exe;wslhost.exe;wslrelay.exe;wslservice.exe;wslserviceproxystub.dll;wslinstall.dll;wslaservice.exe;wslaserviceproxystub.dll;wsladiag.exe;wslc.exe) |
There was a problem hiding this comment.
WINDOWS_BINARIES/BINARIES_DEPENDENCIES are derived from PACKAGE_INPUT_DIR (signed binaries in pipeline builds), but the WiX template currently sources wslaservice.exe and wslaserviceproxystub.dll from ${BIN}. With this change, the build can successfully sign/copy wslaserviceproxystub.dll into PACKAGE_INPUT_DIR yet still produce an MSI containing the unsigned ${BIN} versions. Update the WiX template’s wslaservice component to source these files from ${PACKAGE_INPUT_DIR} (and keep the dependency list aligned with whatever path the MSI actually consumes).
|
Included these fixes in #14185 |
No description provided.