Disable the process creation cursor animation by default#14293
Merged
Disable the process creation cursor animation by default#14293
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the common Windows SubProcess helper to disable the process-creation cursor feedback animation by default (via STARTF_FORCEOFFFEEDBACK), while explicitly preserving the default cursor feedback behavior for interop-launched processes.
Changes:
- Extend
wsl::windows::common::SubProcessto acceptStartupFlagsand default it toSTARTF_FORCEOFFFEEDBACK. - Plumb
StartupFlagsintoSTARTUPINFOEX::StartupInfo.dwFlagsduring process creation. - Explicitly pass
StartupFlags = 0for interop process creation to avoid altering cursor feedback for potentially interactive GUI processes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/windows/common/interop.cpp | Opts interop process creation out of the new default by passing StartupFlags = 0. |
| src/windows/common/SubProcess.h | Adds StartupFlags parameter (defaulting to STARTF_FORCEOFFFEEDBACK) and stores it on the class. |
| src/windows/common/SubProcess.cpp | Applies m_startupFlags into STARTUPINFOEX.StartupInfo.dwFlags when starting the process. |
benhillis
approved these changes
Feb 26, 2026
Member
benhillis
left a comment
There was a problem hiding this comment.
Awesome, I did not know about this flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This sets the
STARTF_FORCEOFFFEEDBACKby default whenever we create new Windows processes.This particularly useful during testing, since it prevents the cursor from jumping between "normal" and "process creation pending" state back and forth.
The flag is left untouched when creating interop processes, since this path can create interactive GUI processes on behalf of the user
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed