Impersonate caller in ResizeDistribution VHD operations#40253
Merged
Impersonate caller in ResizeDistribution VHD operations#40253
Conversation
Add scoped wil::CoImpersonateClient() around VHD file operations in ResizeDistribution so that file access is checked against the calling user's permissions rather than running as SYSTEM. Both the grow and shrink paths are covered. VM operations remain as SYSTEM. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WSL service’s ResizeDistribution implementation to perform host-side VHD open/size/resize operations while impersonating the COM caller, ensuring the underlying VHD file access is evaluated against the calling user’s permissions instead of SYSTEM.
Changes:
- Added scoped
wil::CoImpersonateClient()around VHD open/size/resize calls in both grow and shrink paths. - Refactored local variables (
configurationconst,vhdPathalias) to reuse the resolved VHD path consistently.
OneBlue
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scoped
wil::CoImpersonateClient()around VHD file operations inResizeDistributionso that file access is checked against the calling user's permissions rather than running as SYSTEM. Both the grow and shrink paths are covered. VM operations remain as SYSTEM.