Skip to content

Disable shared compilation when building wslsettings#40289

Merged
OneBlue merged 2 commits intomasterfrom
user/oneblue/settings-build-fix
Apr 23, 2026
Merged

Disable shared compilation when building wslsettings#40289
OneBlue merged 2 commits intomasterfrom
user/oneblue/settings-build-fix

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented Apr 23, 2026

Summary of the Pull Request

This change attempts to fix a recurring build error that the release pipeline hits when building wslsettings (CS0016).

I'm not 100% certain that this will resolve the issue, but it's worth trying. Will revert if we still see it after this is merged

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings April 23, 2026 19:18
@OneBlue OneBlue requested a review from a team as a code owner April 23, 2026 19:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to mitigate intermittent Roslyn build failures (CS0016) in the release pipeline when building wslsettings by disabling the shared compilation server (VBCSCompiler) via an MSBuild property.

Changes:

  • Add an MSBuild PropertyGroup setting UseSharedCompilation=false for the wslsettings build.

Comment thread src/windows/wslsettings/directory.build.targets.in Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 19:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@OneBlue OneBlue merged commit c9effdc into master Apr 23, 2026
13 checks passed
@OneBlue OneBlue deleted the user/oneblue/settings-build-fix branch April 23, 2026 21:34
OneBlue added a commit that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants