Conversation
marcelwgn
reviewed
Jul 4, 2023
Contributor
marcelwgn
left a comment
marcelwgn
left a comment
There was a problem hiding this comment.
I can only second what @Jay-o-Way said, otherwise this looks fine.
Collaborator
Author
|
@chingucoding @Jay-o-Way Thanks! Addressed your feedback! |
Collaborator
|
Please rebase from main to get the latest CI build fixes and run an Accessibility Insights pass on the updated xaml pages. (Automated test pass coming soon!) |
karkarl
approved these changes
Oct 16, 2023
Jay-o-Way
reviewed
Oct 19, 2023
Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Collaborator
|
@niels9001 Can you rebase from main to get the test failure fix? |
Collaborator
Author
Done! CI should hopefully pass now :) |
marcelwgn
approved these changes
Nov 1, 2023
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Typography: - Make the copy button always visible - Optimized fontsizes for better readability Colors: - Small fixes to color labels/brush names - Replace the default copy button with the `CopyButton`. --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Typography:
Colors:
CopyButton.Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes