Skip to content

Fix settings icon not properly animating, minor refactor#1313

Merged
marcelwgn merged 7 commits intomicrosoft:mainfrom
marcelwgn:dev/870-fix-settings-icon-animation-lag
Nov 1, 2023
Merged

Fix settings icon not properly animating, minor refactor#1313
marcelwgn merged 7 commits intomicrosoft:mainfrom
marcelwgn:dev/870-fix-settings-icon-animation-lag

Conversation

@marcelwgn
Copy link
Contributor

Description

Motivation and Context

Fixes #870

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn marcelwgn merged commit 14c6712 into microsoft:main Nov 1, 2023
@marcelwgn marcelwgn deleted the dev/870-fix-settings-icon-animation-lag branch November 1, 2023 13:05
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fixes #870
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Settings NavigationViewItem doesn't play the full animation

2 participants