Skip to content

Fix sample presenter not properly determing if its empty #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karkarl merged 1 commit into from
Oct 17, 2023
Merged

Fix sample presenter not properly determing if its empty #1374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WinUIGallery/Controls/SampleCodePresenter.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public IList<ControlExampleSubstitution> Substitutions
set { SetValue(SubstitutionsProperty, value); }
}

public bool IsEmpty => Code.Length == 0 && CodeSourceFile == null;
public bool IsEmpty => string.IsNullOrEmpty(Code) && string.IsNullOrEmpty(CodeSourceFile);

private string actualCode = "";
private static Regex SubstitutionPattern = new Regex(@"\$\(([^\)]+)\)");
Expand All @@ -87,7 +87,7 @@ private static void OnDependencyPropertyChanged(DependencyObject target, Depende

private void ReevaluateVisibility()
{
if (Code.Length == 0 && CodeSourceFile == null)
if (IsEmpty)
{
Visibility = Visibility.Collapsed;
}
Expand Down