Skip to content

Turn off trimming (until it works with Gallery). Turn off Self-Contai…#1377

Closed
bpulliam wants to merge 1 commit intomicrosoft:mainfrom
bpulliam:untrimming
Closed

Turn off trimming (until it works with Gallery). Turn off Self-Contai…#1377
bpulliam wants to merge 1 commit intomicrosoft:mainfrom
bpulliam:untrimming

Conversation

@bpulliam
Copy link
Contributor

  • Turn off trimming (until it works with Gallery)
  • Turn off Self-Contained for public repo

Description

Trimming does not yet work and was causing crashes in Release builds.
This will be re-enabled once the issues are resolved.

@bpulliam bpulliam requested a review from Scottj1s October 10, 2023 14:50
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding PR while investigating trimming issue (since this worked with .NET 6). also, SelfContained is for .NET (not WinAppSDK) so should always be true.

@Scottj1s
Copy link
Member

see #1378

@bpulliam bpulliam closed this Oct 10, 2023
@bpulliam bpulliam deleted the untrimming branch October 10, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants