Skip to content

Set TrimMode explicitly back to partial for .NET 7 compat #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scottj1s merged 1 commit into from
Oct 10, 2023
Merged

Set TrimMode explicitly back to partial for .NET 7 compat #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-arm64-unpackaged.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>ARM64</Platform>
<RuntimeIdentifier>win10-arm64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-arm64.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>ARM64</Platform>
<RuntimeIdentifier>win10-arm64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x64-unpackaged.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x64</Platform>
<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x64.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x64</Platform>
<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x86-unpackaged.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x86</Platform>
<RuntimeIdentifier>win10-x86</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x86.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x86</Platform>
<RuntimeIdentifier>win10-x86</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>