Merged
Conversation
marcelwgn
approved these changes
Nov 18, 2023
Contributor
marcelwgn
left a comment
marcelwgn
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning that up. Is it correct that some controls/sections still don't have an icon (e.g. the text section)?
Jay-o-Way
suggested changes
Nov 19, 2023
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
This PR removes a bunch of unused control icon assets and the links in the `ControlDataInfo.json`. It also renames `ImageIconPath` to `IconGlyph` as we are using those for the navview and are actual icons vs. image :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of unused control icon assets and the links in the
ControlDataInfo.json. It also renamesImageIconPathtoIconGlyphas we are using those for the navview and are actual icons vs. image :).