Skip to content

change Windows App Runtime version to actually reflect runtime, not SDK#1406

Merged
Scottj1s merged 2 commits intomainfrom
user/sjones/war_version
Nov 20, 2023
Merged

change Windows App Runtime version to actually reflect runtime, not SDK#1406
Scottj1s merged 2 commits intomainfrom
user/sjones/war_version

Conversation

@Scottj1s
Copy link
Copy Markdown
Member

Note: Microsoft.WindowsAppRuntime.Insights.Resource.dll is the only module that carries complete version info.

Copy link
Copy Markdown
Contributor

@codendone codendone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Scottj1s Scottj1s merged commit d12f45a into main Nov 20, 2023
@karkarl karkarl deleted the user/sjones/war_version branch February 12, 2024 23:50
@Jay-o-Way
Copy link
Copy Markdown
Contributor

Question: what if there is an issue with something like windowsAppRuntimeVersion.First()? Like, empty collection or something like that...

@Scottj1s
Copy link
Copy Markdown
Member Author

Question: what if there is an issue with something like windowsAppRuntimeVersion.First()? Like, empty collection or something like that...

First() will throw InvalidOperationException if the collection is empty. This is not expected here.

@Jay-o-Way
Copy link
Copy Markdown
Contributor

Jay-o-Way commented Apr 25, 2024

@Scottj1s I was looking at #1528 = #1477 at the time. #1480 holds the solution.

@Scottj1s
Copy link
Copy Markdown
Member Author

ah, thanks for the explanation. I'll follow up on #1480.

karkarl pushed a commit that referenced this pull request Jul 15, 2024
…DK (#1406)

Note: Microsoft.WindowsAppRuntime.Insights.Resource.dll is the only
module that carries complete version info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants