Fix app crash trying to show the search results page#1439
Conversation
…ataPath item's ImagePath is null Fixes microsoft#1438
|
Thanks so much for the fix! We should definitely add a test to avoid future regressions, do you mind appending that to this PR? |
Good point!
All NuGet packages are installed. I also updated them but got the same exception... I need to find time to take a look at this later. Any tips? |
|
Hi @AndrewKeepCoding thank you for creating this PR! Can you try running the WinUI Gallery Packaged workload from Visual Studio and then see if the testsw are able to pick up the application? If that does not help, can you try running the following command |
|
@marcelwgn Thanks for the tips. It worked but not sure if it was the WinAppDriver version (v1.2.99 -> v1.2.1) or the "alternatives" on the instructions...🙃 @karkarl I added an UI test that shows the results page and click each group result menu item. Let me know if can improve it since this is my first time writing a test with WinAppDriver.🙃 |
Thanks so much for your help! I've added some suggestions to your PR, can't wait to get this in! |
|
@karkarl Thanks for the tips. Updated the test. |
|
/azp run |
## Description Set the placeholder image "Placeholder.png" in case that ControlInfoDataPath item's ImagePath is null. ## Motivation and Context Fixes #1438.

Description
Set the placeholder image "Placeholder.png" in case that ControlInfoDataPath item's ImagePath is null.
Motivation and Context
Fixes #1438.
How Has This Been Tested?
Tested on the updated app.
Screenshots (if appropriate):
Types of changes