Skip to content

Fix app crash trying to show the search results page#1439

Merged
karkarl merged 3 commits intomicrosoft:mainfrom
AndrewKeepCoding:fix-app-crash-trying-to-show-search-results-page
Feb 27, 2024
Merged

Fix app crash trying to show the search results page#1439
karkarl merged 3 commits intomicrosoft:mainfrom
AndrewKeepCoding:fix-app-crash-trying-to-show-search-results-page

Conversation

@AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Feb 1, 2024

Description

Set the placeholder image "Placeholder.png" in case that ControlInfoDataPath item's ImagePath is null.

Motivation and Context

Fixes #1438.

How Has This Been Tested?

Tested on the updated app.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl
Copy link
Collaborator

karkarl commented Feb 5, 2024

Thanks so much for the fix! We should definitely add a test to avoid future regressions, do you mind appending that to this PR?

@AndrewKeepCoding
Copy link
Contributor Author

AndrewKeepCoding commented Feb 6, 2024

Thanks so much for the fix! We should definitely add a test to avoid future regressions, do you mind appending that to this PR?

Good point!
But I'm having issues trying to run the UI Tests. I followed the instructions but I'm getting the exceptions below:

image

All NuGet packages are installed. I also updated them but got the same exception...

I need to find time to take a look at this later. Any tips?

@marcelwgn
Copy link
Contributor

Hi @AndrewKeepCoding thank you for creating this PR! Can you try running the WinUI Gallery Packaged workload from Visual Studio and then see if the testsw are able to pick up the application?

If that does not help, can you try running the following command Get-AppxPackage and show the packages that have WinUI3ControlsGallery in the name?

@AndrewKeepCoding
Copy link
Contributor Author

@marcelwgn Thanks for the tips. It worked but not sure if it was the WinAppDriver version (v1.2.99 -> v1.2.1) or the "alternatives" on the instructions...🙃

@karkarl I added an UI test that shows the results page and click each group result menu item. Let me know if can improve it since this is my first time writing a test with WinAppDriver.🙃

@karkarl
Copy link
Collaborator

karkarl commented Feb 22, 2024

@karkarl I added an UI test that shows the results page and click each group result menu item. Let me know if can improve it since this is my first time writing a test with WinAppDriver.🙃

Thanks so much for your help! I've added some suggestions to your PR, can't wait to get this in!

@AndrewKeepCoding
Copy link
Contributor Author

@karkarl Thanks for the tips. Updated the test.

@karkarl
Copy link
Collaborator

karkarl commented Feb 27, 2024

/azp run

@karkarl karkarl merged commit bf8f076 into microsoft:main Feb 27, 2024
@AndrewKeepCoding AndrewKeepCoding deleted the fix-app-crash-trying-to-show-search-results-page branch February 27, 2024 23:41
karkarl pushed a commit that referenced this pull request Jul 15, 2024
## Description
Set the placeholder image "Placeholder.png" in case that
ControlInfoDataPath item's ImagePath is null.

## Motivation and Context
Fixes #1438.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The app crashes trying to show the search results page

3 participants