Skip to content

Implement better keyboard handling, add missing navigation shortcuts/keys#1482

Merged
karkarl merged 2 commits intomicrosoft:mainfrom
marcelwgn:dev/hotkey-navigation-support-1465
Apr 23, 2024
Merged

Implement better keyboard handling, add missing navigation shortcuts/keys#1482
karkarl merged 2 commits intomicrosoft:mainfrom
marcelwgn:dev/hotkey-navigation-support-1465

Conversation

@marcelwgn
Copy link
Contributor

Description

Adding support for X1/X2 Mouse Button and WinKey + Backspace to navigate.
With this PR, we are also switching to KeyboardProcHook since the old way didn't allow us to handle WinKey+Backspace to navigate back.

Motivation and Context

Fixes #1465

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit 🙂

Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
@karkarl
Copy link
Collaborator

karkarl commented Mar 28, 2024

/azp run

@karkarl karkarl merged commit 1a66172 into microsoft:main Apr 23, 2024
karkarl pushed a commit that referenced this pull request Jul 15, 2024
…keys (#1482)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

Adding support for X1/X2 Mouse Button and WinKey + Backspace to
navigate.
With this PR, we are also switching to KeyboardProcHook since the old
way didn't allow us to handle WinKey+Backspace to navigate back.

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fixes #1465

---------

Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Win+Backspace does not navigate back

3 participants