Merged
Conversation
Collaborator
|
I worry this UI makes it so that it's not scalable, for example if more System sounds are added. However, I don't foresee more to be added in the near future, so the convenience of individual buttons should be more valuable. |
Collaborator
|
/azp run |
karkarl
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See screenshot.
Motivation and Context
Previously the sound demo requires toggling the ComboBox, but the ComboBox itself will have an element sound too, causing some confusion. Also the ComboBox item ordering is incorrect (MovePrevious -> MoveNext is the correct order)
How Has This Been Tested?
Manual
Screenshots (if appropriate):
Types of changes