Skip to content

Fix: Prevent FilePicker button double-click#1580

Merged
marcelwgn merged 1 commit intomicrosoft:mainfrom
HO-COOH:fix/filepicker
Dec 13, 2024
Merged

Fix: Prevent FilePicker button double-click#1580
marcelwgn merged 1 commit intomicrosoft:mainfrom
HO-COOH:fix/filepicker

Conversation

@HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Jul 9, 2024

Description

This PR will prevent double-clicking the button, preventing two FilePicker dialogs to appear at the same time.

Motivation and Context

Currently, if you click the buttons on FilePicker page fast enough, two FilePicker dialogs will show up. Code examples are also added to show a correct implementation.

How Has This Been Tested?

Manual.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl
Copy link
Collaborator

karkarl commented Sep 27, 2024

/azp run

2 similar comments
@niels9001
Copy link
Collaborator

/azp run

@marcelwgn
Copy link
Contributor

/azp run

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Dec 13, 2024

I have no access to the CI build logs. Please fix it so we can contribute more easily. What are the errors?

@marcelwgn marcelwgn merged commit 2b84b51 into microsoft:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants