Skip to content

Add a icon to the exe file#1604

Merged
karkarl merged 1 commit intomicrosoft:mainfrom
MGGSK:iconfix
Aug 27, 2024
Merged

Add a icon to the exe file#1604
karkarl merged 1 commit intomicrosoft:mainfrom
MGGSK:iconfix

Conversation

@MGGSK
Copy link
Contributor

@MGGSK MGGSK commented Aug 13, 2024

Added a icon to the apps exe file.

Description

Set the exe icon in the project properties to "Assets\Tiles\GalleryIcon.ico"

Motivation and Context

Don't know why the exe doesn't have an icon.
Fixed this issue: #1600

How Has This Been Tested?

No testing needed.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@MGGSK MGGSK marked this pull request as ready for review August 13, 2024 15:39
@karkarl
Copy link
Collaborator

karkarl commented Aug 15, 2024

Thanks so much for the fix!

@karkarl
Copy link
Collaborator

karkarl commented Aug 15, 2024

/azp run

@karkarl karkarl merged commit 2965bc4 into microsoft:main Aug 27, 2024
@MGGSK MGGSK deleted the iconfix branch August 27, 2024 18:39
@Jay-o-Way
Copy link
Contributor

can you confirm if this solves #1512?

@MGGSK
Copy link
Contributor Author

MGGSK commented Aug 29, 2024

can you confirm if this solves #1512?

That was already fixed before my pull request.

@skalsi-pexip
Copy link

skalsi-pexip commented Oct 15, 2025

TL;DR - this issue is live and needs to be re-opened. I can repo this by downloading WinUI-Gallary from the Store and observing a generic Windows App Icon not the ico in this pr. Here's images:

I am troubleshooting why my WinUI3 App does not have a 16x16 Asset appearing when I have supplied all of the Visual Assets in the package.appxmanifest.

It seems I'm not alone as the WinUi3 App has the same issue!

image image

I did try the code in this PR and it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Did you forget to add an app icon to the WinUI 3 Gallery main application?

4 participants