Skip to content

Fix theming in spacing page#1639

Merged
karkarl merged 1 commit intomicrosoft:mainfrom
marcelwgn:dev/spacing-page-theme-issue
Nov 13, 2024
Merged

Fix theming in spacing page#1639
karkarl merged 1 commit intomicrosoft:mainfrom
marcelwgn:dev/spacing-page-theme-issue

Conversation

@marcelwgn
Copy link
Contributor

Description

Fixing text on spacing page being hard to read when using the theme switch button. This was caused because we didn't include SampleThemeListener and the default behavior of ItemsPages is to switch the theme of the entire page if none are used in a sample page.

Motivation and Context

Fixes #1637

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

/azp run

@karkarl karkarl merged commit af8a673 into microsoft:main Nov 13, 2024
@marcelwgn marcelwgn deleted the dev/spacing-page-theme-issue branch December 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spacing Page → Incorrect Highlighting on Theme Toggle

2 participants