Skip to content

Improve Color page sample code#1653

Merged
niels9001 merged 4 commits intomicrosoft:mainfrom
AndrewKeepCoding:improve-color-page-sample-code
Dec 6, 2024
Merged

Improve Color page sample code#1653
niels9001 merged 4 commits intomicrosoft:mainfrom
AndrewKeepCoding:improve-color-page-sample-code

Conversation

@AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Nov 14, 2024

Description

Added sample code for the theme resource brush use.

Motivation and Context

How Has This Been Tested?

Ran the app and confirme the change.

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@niels9001
Copy link
Collaborator

Could we do just the XAML string as a code block and not the Expander? The core functionality of this tool is to quickly look up brushes, having the expander here would introduce additional scrolling and pushes down the most important info.. thoughts?

@AndrewKeepCoding
Copy link
Contributor Author

Something like this?

image

@karkarl karkarl requested a review from niels9001 November 14, 2024 23:10
@niels9001
Copy link
Collaborator

Nit: can we shorten the 'Text="..."' and keep everything on a single line?

@AndrewKeepCoding
Copy link
Contributor Author

Nit: can we shorten the 'Text="..."' and keep everything on a single line?

Pushed the changes.
image

@karkarl
Copy link
Collaborator

karkarl commented Dec 6, 2024

/azp run

@niels9001 niels9001 merged commit 7d6b14d into microsoft:main Dec 6, 2024
@AndrewKeepCoding AndrewKeepCoding deleted the improve-color-page-sample-code branch December 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants