Skip to content

[UX] New icon#1667

Merged
niels9001 merged 6 commits intomainfrom
niels9001/new-icon
Dec 6, 2024
Merged

[UX] New icon#1667
niels9001 merged 6 commits intomainfrom
niels9001/new-icon

Conversation

@niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Nov 25, 2024

Description

This PR adds the new WinUI Gallery icon, that is part of the new WASDK/WinUI icon family.

  • Updated the tile/icon assets with the new logo.
  • Updated the readme with new images, and added a screenshot to the readme, so new developers understand what the app would look like
  • Updated the "Getting started" icon with the new WinUI logo: it is about Getting started with WinUI after all, so having the WinUI logo there makes much more sense!

Screenshots (if appropriate):

image
image

image

@Jay-o-Way
Copy link
Contributor

Maybe this icon should be used for this repo too

@Jay-o-Way
Copy link
Contributor

Here you add the "3" to the app name in ReadMe, and in #1660 you specifically remove it. What's the full name?

@niels9001 niels9001 mentioned this pull request Nov 26, 2024
3 tasks
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating our icon! It seems that our readme links are now broken so I'm holding off on approving this until we find the issue.

P.S: Thank you for removing the old images

@niels9001 niels9001 requested a review from marcelwgn December 2, 2024 16:25
@karkarl
Copy link
Collaborator

karkarl commented Dec 6, 2024

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Dec 6, 2024

Wondering why we need 5 million versions of the icon in the repo and .csproj? :)

@niels9001
Copy link
Collaborator Author

Wondering why we need 5 million versions of the icon in the repo and .csproj? :)

This is the output from the design file. It ensures that the icon is crisp on every DPI/resolution combo.

When using the tool in the Package manifest, it generates different files from a single image, and as a result, the icon isn't as crisp.

If only we could just set an .ico or .svg 🫠

@niels9001 niels9001 merged commit b5b6d88 into main Dec 6, 2024
@Jay-o-Way
Copy link
Contributor

@niels9001 I think there's an issue with the icon in the top-left of the window. The file BadgeLogo (at 100%) is 24×24 pixels. In the XAML, the icon is scaled to 18px. This makes it unsharp.

@niels9001 niels9001 deleted the niels9001/new-icon branch February 5, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants