Add titlebar height setting sample#1711
Merged
karkarl merged 5 commits intomicrosoft:mainfrom Jan 10, 2025
InfyniteHeap:add-titlebar-height-setting-sample
Merged
Add titlebar height setting sample#1711karkarl merged 5 commits intomicrosoft:mainfrom InfyniteHeap:add-titlebar-height-setting-sample
karkarl merged 5 commits intomicrosoft:mainfrom
InfyniteHeap:add-titlebar-height-setting-sample
Conversation
added 3 commits
December 24, 2024 22:09
Contributor
|
Is this based on on the new experimental titlebar control (coming hopefully in WASDK 1.7) maybe? I think there's an issue with the phrasing like "... now allows ..." It is unclear what "now" means: is it a SDK version, a specific date or something else? And if it relies on a SDK version, this must be clearly mentioned. Besides that: try and keep redundancy to a minimum and use normal sentence casing (see "Titlebar customizations") |
MGGSK
suggested changes
Jan 3, 2025
karkarl
approved these changes
Jan 9, 2025
Collaborator
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a sample to demonstrate how to set the height of titlebar after extending contents into titlebar.
Motivation and Context
WinUI supports to set titlebar height, but the
TitleBarpage doesn't contain a sample to that.How Has This Been Tested?
Just build and run this app, and trun to
TitleBarpage, and then test whether the combobox works as expected.Screenshots (if appropriate):
Types of changes