Skip to content

Fix crash on Bindings page#1740

Merged
niels9001 merged 7 commits intomicrosoft:mainfrom
AndrewKeepCoding:xaml-fundamentals-binding-page-fix
Feb 5, 2025
Merged

Fix crash on Bindings page#1740
niels9001 merged 7 commits intomicrosoft:mainfrom
AndrewKeepCoding:xaml-fundamentals-binding-page-fix

Conversation

@AndrewKeepCoding
Copy link
Contributor

Description

Set the text directly to avoid exceptions by FallbackValue.

Motivation and Context

Fixes #1734 .

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AndrewKeepCoding AndrewKeepCoding marked this pull request as draft February 2, 2025 07:09
@Zakariathr22
Copy link
Contributor

@AndrewKeepCoding
#1734 (comment)

This might be a better fix

@AndrewKeepCoding AndrewKeepCoding marked this pull request as ready for review February 4, 2025 11:42
@niels9001 niels9001 requested a review from marcelwgn February 5, 2025 09:14
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, no longer crashing! Thanks!

@niels9001
Copy link
Collaborator

/azp run

@niels9001 niels9001 merged commit 3b90cba into microsoft:main Feb 5, 2025
1 check passed
@AndrewKeepCoding AndrewKeepCoding deleted the xaml-fundamentals-binding-page-fix branch February 5, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bindings page crashes

3 participants