[WinUI3 Gallery] [RichEditBox]: On applying Text Scaling to 200%, 'Enter search text' placeholder text is getting trimmed#1741
Merged
akanpatel2206 merged 3 commits intomainfrom Feb 4, 2025
Conversation
…er search text' placeholder text is getting trimmed
Hemantxk
reviewed
Feb 3, 2025
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
Hemantxk
approved these changes
Feb 3, 2025
hiteshkrmsft
approved these changes
Feb 3, 2025
sabareesanms
approved these changes
Feb 3, 2025
Saharsh979
approved these changes
Feb 3, 2025
godlytalias
reviewed
Feb 3, 2025
marcelwgn
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WinUI3 Gallery] [RichEditBox]: On applying Text Scaling to 200%, 'Enter search text' placeholder text is getting trimmed.
Description
Removed the
Widthproperty from theTextBoxelement in theRichEditBoxPage.xamlfile to prevent the placeholder text from getting trimmed when applying Text Scaling to 200Motivation and Context
This is an Accessibility issue. User with low vision who rely on text scaling will be impacted and will face difficulties if the placeholder gets trimmed on application of Text Scaling to 200.
How Has This Been Tested?
Made the changes in the code and tested the scenario by applying Text Scaling to 200% and verified that the placeholder text is not getting trimmed.
Screenshots (if appropriate):
For scaling 225:
For scaling 100:
Types of changes