Skip to content

ScratchPadPage.xaml was broken, Grid was blocked#1759

Merged
marcelwgn merged 2 commits intomicrosoft:mainfrom
Jay-o-Way:fix-ScratchPadPage
Feb 13, 2025
Merged

ScratchPadPage.xaml was broken, Grid was blocked#1759
marcelwgn merged 2 commits intomicrosoft:mainfrom
Jay-o-Way:fix-ScratchPadPage

Conversation

@Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Feb 12, 2025

Description

I noticed that the interactive area of the page did not receive any mouse input. Keyboard did work. I saw that conversion for RowDefinitions="*, Auto" was applied to the incorrect (child) Grid, causing the TextBlock to be in the same Grid cell as the RichInput.

Motivation and Context

Fix blocked input

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Jay-o-Way
Copy link
Contributor Author

Reference: 99b73da
FYI @niels9001

@niels9001 niels9001 self-requested a review February 12, 2025 15:46
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @Jay-o-Way! Thanks! Pushed some other XAML improvements cleaning things up!

@Jay-o-Way
Copy link
Contributor Author

I had the same idea about the Grids! 🙂

@niels9001
Copy link
Collaborator

/azp run

@marcelwgn marcelwgn merged commit 4d28fe2 into microsoft:main Feb 13, 2025
2 checks passed
@Jay-o-Way Jay-o-Way deleted the fix-ScratchPadPage branch February 13, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants