Skip to content

Fix auto-scrolling issue on the TabView page#1767

Merged
marcelwgn merged 1 commit intomicrosoft:mainfrom
AndrewKeepCoding:tabview-page-scrolling-fix
Feb 16, 2025
Merged

Fix auto-scrolling issue on the TabView page#1767
marcelwgn merged 1 commit intomicrosoft:mainfrom
AndrewKeepCoding:tabview-page-scrolling-fix

Conversation

@AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Feb 13, 2025

Description

Closes #815.
This PR fixes an auto-scrolling issue on the TabView page.
What I found out is that the TabView control is firering BringIntoViewRequested events when TabWidthMode is set to SizeToContent or Compact. Handling the BringIntoViewRequested event stopped the auto-scrolling.

Motivation and Context

How Has This Been Tested?

Ran the app and verified the changes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for fixing this after all these years! I wonder if this might be a TabView issue that we are working around here 🤔

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn merged commit 1cbc87e into microsoft:main Feb 16, 2025
2 checks passed
@AndrewKeepCoding AndrewKeepCoding deleted the tabview-page-scrolling-fix branch February 25, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigating to TabView scrolls automatically scrolls to the bottom

2 participants