Remove input validation page#1773
Conversation
AndrewKeepCoding
left a comment
AndrewKeepCoding
left a comment
There was a problem hiding this comment.
We can also remove the related string resources on Resources.resw.
I'm wondering, do we even need |
|
In general, the Strings/en-US/Resources.resw file is used with |
|
What about the navigation? |
|
|
@Zakariathr22 @AndrewKeepCoding Can we remove the Resources.resw file in a seperate PR? Just want to make sure we can cleanly merge this in case we need to revert because of the resw being used by anything |
Agreed. |
|
/azp run |
<!--- Provide a general summary of your changes in the Title above --> ## Description Related to this #1773 (comment) **Note:** Some resources in `Resources.resw` are used in the `InputValidation` page. Please ensure that PR #1773 is merged before merging this one. The rest of the resources never been used in the app ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
4 participants
Description
Remove the Input Validation page from the gallery as it has never been used (was disabled) and currently has no functionality. We can add it back once input validation is available in WinUI.
Motivation and Context
Closes #1760
How Has This Been Tested?
Manually Tested
Screenshots (if appropriate):
Types of changes