Add `AppWindow` Sample by Zakariathr22 · Pull Request #1781 · microsoft/WinUI-Gallery

Zakariathr22 · 2025-02-18T18:51:45Z

Description

This PR adds an AppWindow sample to the Gallery. Main changes:

Added sample info to ControlInfoData.json.
Added AppWindowPage.
Added sample windows.
Added sample code files.

The examples demonstrate AppWindow and its presenters like OverlappedPresenter, FullScreenPresenter, and CompactOverlayPresenter, along with their properties and functionalities.

Motivation and Context

Closes #1771
Closes #1552

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

…lery into AppWindow

WinUIGallery/Samples/ControlPages/AppWindowPage.xaml

niels9001

VERY excited to see this 😄!!!

I know this is still in progress but left a few comments

Zakariathr22 · 2025-02-19T17:24:24Z

VERY excited to see this 😄!!!

I know this is still in progress but left a few comments

I'm also excited to finish it. I'll try my best.

Co-authored-by: Niels Laute <niels.laute@live.nl>

…lery into AppWindow

…ndow

…splay area

Zakariathr22 · 2025-02-20T13:35:07Z

@niels9001, we will need a control image for this if it is going to be merged

…close buttons

MGGSK · 2025-02-22T15:12:49Z

Does this close #1552?

Zakariathr22 · 2025-02-22T15:36:25Z

Does this close #1552?

Yes, this addresses the same issue. It closes #1552.
Thanks for pointing to this.

…dow`.

…dow.xaml` and `ModalWindow.xaml.cs`

niels9001 · 2025-02-24T08:35:22Z

@niels9001, we will need a control image for this if it is going to be merged

Here you go!

Zakariathr22 · 2025-02-24T11:06:31Z

Here you go!

Thanks! 😊

Added tooltips for `IsMaximizable` and `IsMinimizable` in `AppWindowPage.xaml` to clarify their functionality. Updated the `SetOwnership` method in `ModalWindow` to rename parameters for better clarity and consistency across `AppWindowSample4_cs.txt` and `ModalWindow.xaml.cs`. A comment was also added to explain how to retrieve the main window from `App.xaml.cs`. (This commit message was generated by Copilot)

Zakariathr22 · 2025-03-03T03:24:54Z

Important

These notes for whoever will review this code:

The modal window example sets the owner using SetWindowLongPtr/SetWindowLong with index -8 (GWL..._HWNDPARENT), ensuring reliable modal behavior. However, I should note that this is an undocumented approach.
This technique has been proven effective in practice. In fact, Raymond Chen demonstrates it in the "PDC 2005 - Five Things Every Win32 Developer Should Know" (minute 52:00, slide 32), underscoring its practical validity.
The method is widely accepted and even utilized in frameworks like WPF, confirming its robustness and dependability in real-world applications.

Based on this, I believe we can proceed with this approach, as the lack of formal documentation does not preclude its effective use.

niels9001

Amazing work! Thanks so much for this contribution @Zakariathr22 !

…ow description

Zakariathr22 · 2025-03-07T13:29:45Z

Amazing work! Thanks so much for this contribution @Zakariathr22 !

You're very welcome! 🚀

The modal window example sets the owner using SetWindowLongPtr/SetWindowLong with index -8 (GWL..._HWNDPARENT), ensuring reliable modal behavior. However, I should note that this is an undocumented approach.

And about the previous note,
I created a PR to document HWNDPARENT (-8) for SetWindowLong_ to clarify window ownership. It was approved and merged, so it's just a matter of time until it's released. No need to worry about it!

For more details, see the PR: MicrosoftDocs/sdk-api#1982.

niels9001 · 2025-03-08T18:23:27Z

/azp run

Zakariathr22 added 5 commits February 18, 2025 10:36

Adding the AppWindow page and inserting its data into ControlInfoData

d254774

Merge branch 'microsoft:main' into AppWindow

b477381

Creating and customizing an AppWindow from a Window instance

d8d3e32

Merge branch 'AppWindow' of https://github.com/Zakariathr22/WinUI-Gal…

b61cf12

…lery into AppWindow

Add AppWindow with Overlaped presenter Example

6eb9fbf

Zakariathr22 changed the title ~~App window~~ Add AppWindow Sample Feb 18, 2025

niels9001 reviewed Feb 19, 2025

View reviewed changes

WinUIGallery/Samples/ControlPages/AppWindowPage.xaml Outdated Show resolved Hide resolved

niels9001 reviewed Feb 19, 2025

View reviewed changes

WinUIGallery/Samples/ControlPages/AppWindowPage.xaml Outdated Show resolved Hide resolved

niels9001 reviewed Feb 19, 2025

View reviewed changes

Zakariathr22 and others added 15 commits February 19, 2025 18:24

Update WinUIGallery/Samples/ControlPages/AppWindowPage.xaml

c9cf35b

Co-authored-by: Niels Laute <niels.laute@live.nl>

New example: modal window with OverlappedPresenter using AppWindow

a9e7872

Merge branch 'AppWindow' of https://github.com/Zakariathr22/WinUI-Gal…

03fb9bf

…lery into AppWindow

Replace ComboBox with TextBox in customizing AppWindow Example

0969d60

Fix: ensuring the main window is activated after closing the modal wi…

b2035ef

…ndow

Upadte first example

258b7ed

Rename SampleWindow2 to SampleWindow3

983188f

Tweak

8fa9d12

New Example: Centering AppWindow on the screen using the available di…

680f1ad

…splay area

New Example: AppWindow with FullScreenPresenter

482bcbe

New Example: AppWindow with CompactOverlayPresenter + other additions

b1b6d81

Migrate sample code to text files

fbf29e0

Apply Mica backdrop to sample windows

fa6d09d

Minor adjustments

4c204fc

Reset the description, subtitle, and docs for the sample

42354dd

Zakariathr22 marked this pull request as ready for review February 20, 2025 13:33

Zakariathr22 requested a review from niels9001 February 20, 2025 13:33

Zakariathr22 added 2 commits February 20, 2025 18:28

Add a close button to the 3rd example +make minor adjustments to the …

3b3d5d3

…close buttons

Tweak

a66a521

Zakariathr22 added 5 commits February 20, 2025 19:29

Add warning InfoBar for AppWindow border and title bar requirement

9091ea8

Tweak

3788ffc

Tweaks

b71c882

Tweaks

b4a3016

Modify modal window to set owner window with fallback to 32-bit

f5033c9

Zakariathr22 added 4 commits February 22, 2025 22:06

Tweaks

9c23b21

Refactored modal window code and renamed SampleWindow4 to `ModalWin…

fbf84b4

…dow`.

Renamed SampleWindow4.xaml and SampleWindow4.xaml.cs to `ModalWin…

7af3895

…dow.xaml` and `ModalWindow.xaml.cs`

Update sample code

74a8a4a

Add the image and the base class of AppWindow

d01dc78

Zakariathr22 mentioned this pull request Feb 25, 2025

Folder structure: Controls, Design, Accessibility, Fundamentals #1744

Open

5 tasks

Merge branch 'microsoft:main' into AppWindow

92ffd15

niels9001 approved these changes Mar 7, 2025

View reviewed changes

Replace "parent window" with "owner window" for clarity in modal wind…

34851d4

…ow description

Merge branch 'main' into AppWindow

769177b

niels9001 enabled auto-merge (squash) March 8, 2025 18:23

niels9001 merged commit 802eb5d into microsoft:main Mar 8, 2025
2 checks passed

Zakariathr22 deleted the AppWindow branch March 8, 2025 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `AppWindow` Sample#1781

Add `AppWindow` Sample#1781
niels9001 merged 36 commits intomicrosoft:mainfrom
Zakariathr22:AppWindow

Zakariathr22 commented Feb 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

niels9001 left a comment

Uh oh!

Zakariathr22 commented Feb 19, 2025

Uh oh!

Zakariathr22 commented Feb 20, 2025 •

edited

Loading

Uh oh!

MGGSK commented Feb 22, 2025

Uh oh!

Zakariathr22 commented Feb 22, 2025 •

edited

Loading

Uh oh!

niels9001 commented Feb 24, 2025

Uh oh!

Zakariathr22 commented Feb 24, 2025

Uh oh!

Zakariathr22 commented Mar 3, 2025

Uh oh!

niels9001 left a comment

Uh oh!

Zakariathr22 commented Mar 7, 2025

Uh oh!

niels9001 commented Mar 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Zakariathr22 commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Uh oh!

Uh oh!

Uh oh!

niels9001 left a comment

Choose a reason for hiding this comment

Uh oh!

Zakariathr22 commented Feb 19, 2025

Uh oh!

Zakariathr22 commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MGGSK commented Feb 22, 2025

Uh oh!

Zakariathr22 commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niels9001 commented Feb 24, 2025

Uh oh!

Zakariathr22 commented Feb 24, 2025

Uh oh!

Zakariathr22 commented Mar 3, 2025

Uh oh!

niels9001 left a comment

Choose a reason for hiding this comment

Uh oh!

Zakariathr22 commented Mar 7, 2025

Uh oh!

niels9001 commented Mar 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Zakariathr22 commented Feb 18, 2025 •

edited

Loading

Zakariathr22 commented Feb 20, 2025 •

edited

Loading

Zakariathr22 commented Feb 22, 2025 •

edited

Loading