Intellicode suggestions

[Jay-o-Way]

Description

Scrolled through code and applied a large number of suggestions. Zero effect on functionality or looks.
I skipped a few, like "mark as readonly/static/partial"; IDE0305 "ToList"; and something with name convention (capital letter or "_" at the beginning)

Context

Linking #1785
Note: this PR is all within the WinUIGallery project.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[niels9001]

Thanks @Jay-o-Way! Review and merging might take a bit more time, since it's pretty huge and we'd want to avoid PRs having conflicts as much as possible :)

[Jay-o-Way]

Thanks! Yeah, I understand this is no priority. I was just wondering -

• Does simplifying the namespace in a CREF matter?
  e.g. /// and <see cref="Page.OnNavigatedFrom"/> events.
• Is this something I could do for PowerToys too?

[Jay-o-Way]

Oh boy, how do I fix those conflicts

[Zakariathr22]

Oh boy, how do I fix those conflicts

I’ve been thinking about this as well 💀.

I suggest that you split this PR into multiple PRs, modifying a part of the project each time. Start with the files that are not being modified now and finish with the other files.

I also suggest opening an issue where you outline your plan.

[Jay-o-Way]

Review and merging might take a bit more time, since it's pretty huge and we'd want to avoid PRs having conflicts as much as possible

But in reality, the longer a PR is open, the more chances of merge conflicts.

[niels9001]

Review and merging might take a bit more time, since it's pretty huge and we'd want to avoid PRs having conflicts as much as possible

But in reality, the longer a PR is open, the more chances of merge conflicts.

Hey @Jay-o-Way We've discussed this with the team and we can't review this PR; it's just too big :(. Although most changes look pretty simple, we'd need to make sure we are not breaking anything.

Can we break this up in smaller PRs? Thinking out loud, I can imagine having a separate PR for the Controls folder, Pages folder etc.