Skip to content

Fix inconsistencies and noop buttons in AppWindow samples#1824

Merged
niels9001 merged 4 commits intomicrosoft:mainfrom
marcelwgn:dev/improve-app-window-samples
Apr 2, 2025
Merged

Fix inconsistencies and noop buttons in AppWindow samples#1824
niels9001 merged 4 commits intomicrosoft:mainfrom
marcelwgn:dev/improve-app-window-samples

Conversation

@marcelwgn
Copy link
Contributor

Description

Fixes:

  • Not all app window samples having a titlebar icon
  • Show/restore buttons not being helpful, making them a "hide/minimize and show/restore after 3 seconds" buttons to showcase API working

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@niels9001 niels9001 enabled auto-merge (squash) April 2, 2025 11:13
@niels9001
Copy link
Collaborator

/azp run

@niels9001 niels9001 merged commit d7d9522 into microsoft:main Apr 2, 2025
2 checks passed
@Zakariathr22
Copy link
Contributor

@marcelwgn
I know this PR has been merged, but in SampleWindow3, there's a possibility to restore the window after maximizing it. I suggest considering this use case in the example as well.

@marcelwgn marcelwgn deleted the dev/improve-app-window-samples branch April 3, 2025 15:45
marcelwgn pushed a commit that referenced this pull request Apr 10, 2025
…res (#1827)

## Description
- Added a maximize then restore button.
- Showcased the `TitleBar.PreferredTheme` feature and set it to
`UseDefaultAppMode` across all sample windows.
- Demonstrated the `SetTaskBarIcon` and `SetTitleBarIcon` methods.
- Updated the sample code to reflect these enhancements and added
explanatory comments for better understanding.

## Motivation and Context
- This change introduces new features from WinAppSDK 1.7.
- Related to this
#1824 (comment).

## How Has This Been Tested?
**Manually tested**

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants