Skip to content

Update PopupPage.xaml#1831

Merged
niels9001 merged 3 commits intomicrosoft:mainfrom
Max-Meng:patch-1
Apr 17, 2025
Merged

Update PopupPage.xaml#1831
niels9001 merged 3 commits intomicrosoft:mainfrom
Max-Meng:patch-1

Conversation

@Max-Meng
Copy link
Contributor

BorderThickness and BorderBrush are properties of the Border control, but they were put in the Popup control, which is incorrect and misleading.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Max-Meng and others added 2 commits April 13, 2025 22:05
BorderThickness and BorderBrush are properties of the Border control, but they were put in the Popup control, which is incorrect and misleading.
@niels9001 niels9001 self-requested a review April 16, 2025 15:40
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@niels9001 niels9001 enabled auto-merge (squash) April 16, 2025 15:41
@niels9001
Copy link
Collaborator

/azp run

@niels9001
Copy link
Collaborator

/azp run

@niels9001 niels9001 merged commit b9b7348 into microsoft:main Apr 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants