Skip to content

Improved source quality in the test projects#1848

Merged
marcelwgn merged 2 commits intomicrosoft:mainfrom
0x5bfa:5bfa/CQ-TestsImprovements
May 30, 2025
Merged

Improved source quality in the test projects#1848
marcelwgn merged 2 commits intomicrosoft:mainfrom
0x5bfa:5bfa/CQ-TestsImprovements

Conversation

@0x5bfa
Copy link
Copy Markdown
Contributor

@0x5bfa 0x5bfa commented Apr 22, 2025

Description

As the title.

Please enable this option to hide space to tab changes.

image

Motivation and Context

The code quality in the test projects was not as good and so, improved it to be consistent.

How Has This Been Tested?

  • Build the test projects

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@0x5bfa

This comment was marked as outdated.

@marcelwgn
Copy link
Copy Markdown
Contributor

Are you guys wanting to use Tabs instead of Spaces for indentation in C#? in XAML, I think Tabs is prefered?

We want to stick with what XAML Styler does per default which seems to be spaces for the properties: https://github.com/Xavalon/XamlStyler/wiki/External-Configurations#indent-with-tabs
Plan is to eventually start using XAML Styler for this repo but we are blocked on property ordering issues.

@0x5bfa

This comment was marked as outdated.

@marcelwgn
Copy link
Copy Markdown
Contributor

We want to stick with what XAML Styler does

Alright. What about C#?

4 spaces as indicated by the .editorconfig.

we are blocked on property ordering issues.

Does that mean you are finding difficulty to decide how properties should be ordered? Or is that a technical issue in this repo?

The issue is that reordering properties changes behavior: microsoft/microsoft-ui-xaml#10347 (comment)

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-TestsImprovements branch from 50d2bd3 to ef6455d Compare May 29, 2025 02:13
@0x5bfa
Copy link
Copy Markdown
Contributor Author

0x5bfa commented May 29, 2025

I think this PR is ready for review.

Copy link
Copy Markdown
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup!

@marcelwgn
Copy link
Copy Markdown
Contributor

/azp run

@marcelwgn marcelwgn enabled auto-merge (squash) May 30, 2025 11:38
@marcelwgn marcelwgn merged commit 1f88f93 into microsoft:main May 30, 2025
2 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-TestsImprovements branch May 30, 2025 13:46
@0x5bfa 0x5bfa mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants