Skip to content

add border to icon#1856

Merged
niels9001 merged 9 commits intomicrosoft:mainfrom
Jay-o-Way:background-for-icon
May 6, 2025
Merged

add border to icon#1856
niels9001 merged 9 commits intomicrosoft:mainfrom
Jay-o-Way:background-for-icon

Conversation

@Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Apr 27, 2025

Description

Adds a border and background to the larger icon in the SidePanel.

Closes #1854

Motivation and Context

Clarity. This shows how any "overlay icons" are placed inside the available area. May help finding the right icon.

Screenshots (if appropriate):

image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags are no longer showing up for me? Please revert those styling changes as they are not in scope for this issue and might introduce regressions with text scaling enabled.

image

@Jay-o-Way Jay-o-Way force-pushed the background-for-icon branch from 00a8d8b to 1c4719c Compare April 27, 2025 13:38
@Zakariathr22
Copy link
Contributor

Out of topic:
It's funny how simply wrapping a FontIcon inside a Border led us to all of this 😂

@niels9001 niels9001 self-requested a review May 5, 2025 08:24
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jay-o-Way Please add the rounded corners (and optional padding to overcome to corner issue) as proposed by the design team, then we can get this in.

Thanks!

@Jay-o-Way
Copy link
Contributor Author

@niels9001 Why don't you just finish it for me. Since we can't seem to agree on anything. Just do it your way.

@niels9001 niels9001 self-requested a review May 5, 2025 10:33
@niels9001 niels9001 enabled auto-merge (squash) May 5, 2025 10:34
Copy link
Contributor Author

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@niels9001
Copy link
Collaborator

/azp run

@niels9001 niels9001 merged commit ff3420b into microsoft:main May 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea: use a border or background on icon

3 participants